lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] lightnvm: pblk: enable line minor version detection
Date
> On 12 Jun 2018, at 04.29, Matias Bjørling <mb@lightnvm.io> wrote:
>
> When recovering a line, an extra check was added when debugging was
> active, such that minor version where also checked. Unfortunately,
> this used the ifdef NVM_DEBUG, which is not correct.
>
> Instead use the proper DEBUG def, and now that it compiles, also fix
> the variable.
>
> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
> Fixes: d0ab0b1ab991f ("lightnvm: pblk: check data lines version on recovery")
> ---
> drivers/lightnvm/pblk-recovery.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
> index 598342833d0d..b1a91cb3ca4d 100644
> --- a/drivers/lightnvm/pblk-recovery.c
> +++ b/drivers/lightnvm/pblk-recovery.c
> @@ -742,9 +742,10 @@ static int pblk_recov_check_line_version(struct pblk *pblk,
> return 1;
> }
>
> -#ifdef NVM_DEBUG
> +#ifdef CONFIG_NVM_PBLK_DEBUG
> if (header->version_minor > EMETA_VERSION_MINOR)
> - pr_info("pblk: newer line minor version found: %d\n", line_v);
> + pr_info("pblk: newer line minor version found: %d\n",
> + header->version_minor);
> #endif
>
> return 0;
> --
> 2.11.0

Good catch.

Reviewed-by: Javier González <javier@cnexlabs.com>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-06-12 16:37    [W:0.057 / U:7.036 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site