lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: pi433: add mutex fixing concurrency issues.
On Sat, Jun 09, 2018 at 11:48:42AM -0400, Hugo Lefeuvre wrote:
> case PI433_IOC_WR_TX_CFG:
> if (copy_from_user(&instance->tx_cfg, argp,
> sizeof(struct pi433_tx_cfg)))
> return -EFAULT;
> break;

Btw, it looks so wrong to me that we copy partial data to
&instance->tx_cfg... I'd really prefer copying it to a tmp buffer and
then verifying it's corrent then memcpy()ing it to &instance->tx_cfg.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-06-12 14:12    [W:0.078 / U:10.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site