lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] isdn/i4l: add error handling for try_module_get
From
Date
On 6/12/2018 7:43 AM, Zhouyang Jia wrote:

> When try_module_get fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling try_module_get.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
> drivers/isdn/i4l/isdn_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c
> index 7c6f3f5..7e52851 100644
> --- a/drivers/isdn/i4l/isdn_common.c
> +++ b/drivers/isdn/i4l/isdn_common.c
> @@ -71,7 +71,8 @@ static int isdn_add_channels(isdn_driver_t *d, int drvidx, int n, int adding);
> static inline void
> isdn_lock_driver(isdn_driver_t *drv)
> {
> - try_module_get(drv->interface->owner);
> + if (!try_module_get(drv->interface->owner))
> + printk(KERN_WARNING "isdn_lock_driver: cannot get module\n");

Do you call this error handling code? :-)
And BTW we have pr_warn() for that.

> drv->locks++;
> }
>

MBR, Sergei

\
 
 \ /
  Last update: 2018-06-12 12:12    [W:0.023 / U:3.428 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site