lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
Date
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

On 6/12/2018 10:51 AM, Zeng Tao wrote:
> In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
> a usb request, the current flow will complete one usb request with no
> hardware transfer, this will lead to a packet drop on the usb bus.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> ---
> drivers/usb/dwc2/gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f0d9ccf..fbe65f6 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
>
> tmp = dwc2_hsotg_read_frameno(hsotg);
> if (using_desc_dma(hsotg)) {
> - dwc2_hsotg_complete_request(hsotg, hs_ep,
> - get_ep_head(hs_ep), 0);
> -
> hs_ep->target_frame = tmp;
> dwc2_gadget_incr_frame_num(hs_ep);
> dwc2_gadget_start_isoc_ddma(hs_ep);
>


\
 
 \ /
  Last update: 2018-06-12 09:49    [W:0.025 / U:0.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site