Messages in this thread | | | Date | Mon, 11 Jun 2018 15:26:02 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH] ALSA: sonicvibes: add error handling for snd_ctl_add |
| |
On Mon, 11 Jun 2018 10:08:40 +0200, Zhouyang Jia wrote: > > When snd_ctl_add fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling snd_ctl_add. > > Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
I postpone this one because the change won't give anything as is although this change itself is correct. If you look at the code closely, the caller of snd_sonicvibes_create_gameport() ignores the return value. So we need to fix two places.
thanks,
Takashi
| |