Messages in this thread | | | From | Dan Williams <> | Date | Fri, 1 Jun 2018 20:37:59 -0700 | Subject | Re: linux-next: manual merge of the nvdimm tree with the xfs tree |
| |
On Fri, Jun 1, 2018 at 6:33 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Darrick, > > On Fri, 1 Jun 2018 17:59:48 -0700 "Darrick J. Wong" <darrick.wong@oracle.com> wrote: >> >> > + if (!dax_enabled) { >> > - pr_debug("VFS (%s): error: dax support not enabled\n", >> > - sb->s_id); >> > + pr_debug("%s: error: dax support not enabled\n", >> > + bdevname(bdev, buf)); >> > - return false; >> > + return -EOPNOTSUPP; >> >> Hang on a sec, the changes in the xfs tree make this function return a >> boolean (true for dax-is-supported, false for dax-not-supported), but >> this change partially reverts the boolean return values. > > OK, weird, that is what I though I had done. Thanks for pointing it > out (I guess it was getting late :-(). > >> > } >> > - >> > - return true; >> > + return 0;
Good catch Darrick, I missed that too...
| |