Messages in this thread Patch in this message | | | From | Finn Thain <> | Subject | [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice | Date | Fri, 1 Jun 2018 23:27:51 -0400 (EDT) |
| |
Clearing the interrupt flag twice in succession creates a theoretical race condition. Fix this.
Tested-by: Stan Johnson <userm57@yahoo.com> Signed-off-by: Finn Thain <fthain@telegraphics.com.au> --- drivers/macintosh/via-pmu.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index 9c94f99e80da..087c3aa5233a 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -1458,7 +1458,6 @@ pmu_sr_intr(void) if (in_8(&via[B]) & TREQ) { printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B])); - out_8(&via[IFR], SR_INT); return NULL; } /* The ack may not yet be low when we get the interrupt */ -- 2.16.1
| |