Messages in this thread | | | Date | Fri, 1 Jun 2018 21:17:24 -0400 (EDT) | From | Mathieu Desnoyers <> | Subject | Re: [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU |
| |
----- On May 31, 2018, at 1:51 PM, Joel Fernandes, Google joel@joelfernandes.org wrote:
>> I find it odd to have a "return" in a macro that consists of a >> do { } while (0). I'm tempted to replace "return" by "break" here, >> to break the macro do/while (0) loop. > > "return;" is also used from "if (!(cond))" above so I prefer be consistent > and just use return than break as done above, but please let me know if you > still object.
It's fine by me,
Thanks!
Mathieu
-- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
| |