Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 1 Jun 2018 17:10:26 +0200 | Subject | Re: [PATCH] fb_omap: add gpiolib dependency |
| |
On Thu, May 31, 2018 at 8:04 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, May 31, 2018 at 12:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: > >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] >> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': >> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > >> Rather than fixing up each one individually, this just marks all of it >> as depending on GPIOLIB. > > Hmm... But the OF stuff is not part of GPIOLIB.
The underlying issue is the same though: linux/gpio.h includes a different set of header files depending on CONFIG_GPIOLIB being set or not. Without it, we are missing all the indirect includes from asm-generic/gpio.h that include linux/of.h and linux/gpio/consumer.h.
Arnd
| |