Messages in this thread | | | Subject | Re: [PATCH net] ipv6: omit traffic class when calculating flow hash | From | Nicolas Dichtel <> | Date | Fri, 1 Jun 2018 14:25:22 +0200 |
| |
Le 01/06/2018 à 12:34, Michal Kubecek a écrit : > Some of the code paths calculating flow hash for IPv6 use flowlabel member > of struct flowi6 which, despite its name, encodes both flow label and > traffic class. If traffic class changes within a TCP connection (as e.g. > ssh does), ECMP route can switch between path. It's also incosistent with nit: s/incosistent/inconsistent
> other code paths where ip6_flowlabel() (returning only flow label) is used > to feed the key. > > Use only flow label everywhere, including one place where hash key is set > using ip6_flowinfo(). > > Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)") > Fixes: f70ea018da06 ("net: Add functions to get skb->hash based on flow structures") > Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
| |