Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 1 Jun 2018 13:39:49 +0300 | Subject | Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable |
| |
On Fri, Jun 1, 2018 at 2:50 AM, Logan Gunthorpe <logang@deltatee.com> wrote: > Separate out the code to match a PCI device with a string (typically > originating from a kernel parameter) from the > pci_specified_resource_alignment() function into its own helper > function. > > While we are at it, this change fixes the kernel style of the function > (fixing a number of long lines and extra parentheses). > > Additionally, make the analogous change to the kernel parameter > documentation: Separating the description of how to specify a PCI device > into it's own section at the head of the pci= parameter. > > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > Reviewed-by: Stephen Bates <sbates@raithlin.com> > Acked-by: Christian König <christian.koenig@amd.com>
Sorry for maybe being late here.
> - pci=option[,option...] [PCI] various PCI subsystem options: > + pci=option[,option...] [PCI] various PCI subsystem options. > + > + Some options herein operate on a specific device > + or a set of devices (<pci_dev>). These are > + specified in one of two formats:
I would rather to add
<pci_dev>
here in the same way as done for options. It would be easy for people to find a referenced paragraph.
> + > + [<domain>:]<bus>:<slot>.<func> > + pci:<vendor>:<device>[:<subvendor>:<subdevice>] > + > + Note: the first format specifies a PCI > + bus/slot/function address which may change > + if new hardware is inserted, if motherboard > + firmware changes, or due to changes caused > + by other kernel parameters. The second format > + selects devices using IDs from the > + configuration space which may match multiple > + devices in the system.
> +static int pci_dev_str_match(struct pci_dev *dev, const char *p, > + const char **endptr)
This change I hope has no functional alteration, so, can be split to a separate patch.
-- With Best Regards, Andy Shevchenko
| |