lkml.org 
[lkml]   [2018]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 13/25] staging: lustre: libcfs: fix libcfs_cpu coding style
On Tue, May 29, 2018 at 10:21:53AM -0400, James Simmons wrote:
> int cfs_cpt_set_nodemask(struct cfs_cpt_table *cptab,
> - int cpt, nodemask_t *mask);
> + int cpt, const nodemask_t *mask);

This is not a coding style change. It is a semi-functional change.
Don't bury code changes in the middle of "cleanup code formatting"
patches, it makes maintainers very grumpy when we notice this as we then
feel like we might have missed other things being snuck by us in the
guise of these types of patches...

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-06-01 10:40    [W:0.138 / U:2.372 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site