Messages in this thread | | | From | Fabio Estevam <> | Date | Wed, 9 May 2018 22:10:41 -0300 | Subject | Re: [PATCH] ARM: DTS: imx53: Add support for imx53 HSC/DDC boards from K+P |
| |
Hi Lukasz,
On Wed, May 9, 2018 at 12:34 PM, Lukasz Majewski <lukma@denx.de> wrote:
> +&iomuxc { > + imx53-kp-ddc {
No need for keeping this imx53-kp-ddc.
> diff --git a/arch/arm/boot/dts/imx53-kp-hsc.dts b/arch/arm/boot/dts/imx53-kp-hsc.dts > new file mode 100644 > index 000000000000..fff358395c9d > --- /dev/null > +++ b/arch/arm/boot/dts/imx53-kp-hsc.dts > @@ -0,0 +1,53 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2018 > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; > +#include "imx53-kp.dtsi" > + > +/ { > + model = "K+P imx53 HSC"; > + compatible = "kiebackpeter,imx53-hsc", "fsl,imx53"; > +
No need for this blank line.
> +}; > + > +&fec { > + status = "okay";
We usually put the status in the last line.
> + gpio_buttons { > + compatible = "gpio-keys"; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpiobuttons>; > + > + button@1 {
You pass @1 without a reg property. This triggers a warning when building with W=1.
You could remove the @1.
Please make sure this patch does not introduce any W=1 dtc warning.
> +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_kp_common>; > + > + imx53-kp-common {
No need for this imx53-kp-common
> +&uart4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart4>; > +
No need for this blank line.
| |