lkml.org 
[lkml]   [2018]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/8] kbuild: remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX and clean-up code
    Hi Masahiro.

    On Wed, May 09, 2018 at 04:23:44PM +0900, Masahiro Yamada wrote:
    >
    > I got acknowledge to remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX entirely.
    > (https://lkml.org/lkml/2018/5/5/148)
    >
    > Several tools can be cleaned-up.
    >
    > Removing the CONFIG option makes VMLINUX_SYMBOL() no-op,
    > so this macro can be removed too.
    Looks good. You can add my:
    Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

    for all patches.
    One minor comment to one patch that I let you decide what to do about.
    The code readability increases everywhere.

    >
    > VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR() are widely used,
    > so it will take some time to kill them entirely.
    > (I will send other patches later, splitting per-arch)

    There are a few files outside arch/ like
    certs/system_certificates.S
    drivers/mtd/chips/gen_probe.c
    kernel/module.c

    They could belong in this none-arch series.

    Sam

    \
     
     \ /
      Last update: 2018-05-09 18:14    [W:3.286 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site