Messages in this thread | | | Subject | Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting | From | Steffen Maier <> | Date | Wed, 9 May 2018 11:05:02 +0200 |
| |
On 05/08/2018 08:43 AM, Ching Huang wrote: > On Tue, 2018-05-08 at 14:32 +0800, Ching Huang wrote: >> On Tue, 2018-05-08 at 01:41 -0400, Martin K. Petersen wrote: >>> Hello Ching, >>> >>>> 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT. >>>> 2. Add slave_configure callback function to set device command timeout value. >>>> 3. Update driver version to v1.40.00.06-20180504. >>> >>> I am not so keen on arcmsr overriding the timeout set by the admin or >>> application. >>> >>> Also, instead of introducing this module parameter, why not simply ask >>> the user to change rq_timeout? >>> >> This timeout setting only after device has been inquiry successfully. >> Of course, user can set timeout value to /sys/block/sdX/device/timeout. >> But user does not like to set this value once command timeout occurred. >> They rather like timeout never happen. >> > This timeout setting apply to all devices, its better than user has to > set one bye one for each device.
Udev rules?
Something roughly like bottom of: https://www.ibm.com/support/knowledgecenter/ST3FR7_8.1.2/com.ibm.storwize.v7000.812.doc/svc_linux_settings.html or better doing the assignment with udev builtins (fix the syntax error with model): https://www.ibm.com/support/knowledgecenter/ST3FR7_8.1.2/com.ibm.storwize.v7000.812.doc/svc_zs_statechange_3fgeri.html
-- Mit freundlichen Grüßen / Kind regards Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
| |