lkml.org 
[lkml]   [2018]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v3 0/4] Restore ULPI USB on Tegra20
Date
Hello,

This series of patches fixes ULPI USB on Tegra20. The original problem
was reported by Marcel Ziswiler, he found that "ulpi-link" clock was
incorrectly set to CDEV2 instead of PLL_P_OUT4. Marcel made a patch
that changed the "ulpi-link" clock to PLL_P_OUT4 and that fixed issue
with the USB for the devices that have CDEV2 being enabled by bootloader.
The patch got into the kernel and later Marc Dietrich found that USB
stopped working on the "paz00" Tegra20 board. After a bit of discussion
was revealed that PLL_P_OUT4 is the parent clock of the CDEV2 and clock
driver was setting CDEV2's parent incorrectly. The parent clock is actually
determined by the pinmuxing config of CDEV2 pingroup. This patchset fixes
the parent of CDEV2 clock by making Tegra's pinctrl driver a clock provider,
providing CDEV1/2 clock muxes (thanks to Peter De Schrijver for the
suggestion), and then setting these clock muxes as parents for the CDEV1/2
clocks. In the end Marcel's CDEV2->PLL_P_OUT4 change is reverted since CDEV2
(aka MCLK2) is the actual clock source for "ulpi-link".

Changelog:

v3:
- Use clk DT ID's instead of comparing clk names and make
custom of_src_onecell_get specific to Tegra20 clk provider
in the "Add quirk for getting CDEV1/2 clocks on Tegra20" patch
as was suggested by Peter De Schrijver for v2.

v2:
- Added new patch "Add quirk for getting CDEV1/2 clocks", assuring
that clk user won't get CDEV1/2 clocks until parent clk muxes
are available, i.e. resolves potential issue with CDEV-user driver
vs pinctrl driver probe order.

- Factored out "pinctrl" patch from the patchset as was requested by
Linus Walleij.

- Addressed v1 review comments: fixed swapped DEV1/2 clk div bits,
made DEV1/2 divs read-only, etc minor changes.

Dmitry Osipenko (4):
clk: tegra20: Add DEV1/DEV2 OSC dividers
clk: tegra20: Correct parents of CDEV1/2 clocks
clk: tegra: Add quirk for getting CDEV1/2 clocks on Tegra20
ARM: dts: tegra20: Revert "Fix ULPI regression on Tegra20"

arch/arm/boot/dts/tegra20.dtsi | 2 +-
drivers/clk/tegra/clk-tegra114.c | 2 +-
drivers/clk/tegra/clk-tegra124.c | 2 +-
drivers/clk/tegra/clk-tegra20.c | 52 +++++++++++++++++++++++++++++---
drivers/clk/tegra/clk-tegra210.c | 2 +-
drivers/clk/tegra/clk-tegra30.c | 2 +-
drivers/clk/tegra/clk.c | 5 +--
drivers/clk/tegra/clk.h | 2 +-
8 files changed, 56 insertions(+), 13 deletions(-)

--
2.17.0

\
 
 \ /
  Last update: 2018-05-08 18:31    [W:0.077 / U:2.324 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site