lkml.org 
[lkml]   [2018]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 12/27] coresight: tmc-etr: Allow commandline option to override SG use
    From
    Date
    On 03/05/18 21:40, Mathieu Poirier wrote:
    > On Tue, May 01, 2018 at 10:10:42AM +0100, Suzuki K Poulose wrote:
    >> The Coresight TMC-ETR SG mode could be unsafe on a platform where
    >> the ETR is not properly connected to account for READ operations.
    >> We use a DT node property to indicate if the system is safe.
    >> This patch also provides a command line parameter to "force"
    >> the use of SG mode to override the firmware information.
    >>
    >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    >> Cc: Mike Leach <mike.leach@linaro.org>
    >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    >> ---
    >> Hi
    >>
    >> This is more of a debug patch for people who may want to
    >> test their platform without too much of hacking. I am not
    >> too keen on pushing this patch in.
    >
    > I am not either nor do I personally need it to test this feature. We can leave
    > it in for now (and subsequent version) if you need it but we agree that I won't
    > queue it to my tree when the time comes.

    OK, I was expecting this view from most of us here. I will drop it from my series in
    the next version.

    Cheers
    Suzuki

    \
     
     \ /
      Last update: 2018-05-08 17:51    [W:5.252 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site