lkml.org 
[lkml]   [2018]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors
    On Fri, May 04, 2018 at 03:56:32PM +0200, Antoine Tenart wrote:
    > SFP connectors can be solder on a board without having any of their pins
    > (LOS, i2c...) wired. In such cases the SFP link state cannot be guessed,
    > and the overall link status reporting is left to other layers.
    >
    > In order to achieve this, a new SFP_DEV status is added, named UNKNOWN.
    > This mode is set when it is not possible for the SFP code to get the
    > link status and as a result the link status is reported to be always UP
    > from the SFP point of view.

    This looks weird to me. SFP_DEV_* states track the netdevice up/down
    state and have little to do with whether LOS or MODDEF0 are implemented.

    I think it would be better to have a new SFP_MOD_* and to force
    sm_mod_state to that in this circumstance.

    --
    RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
    According to speedtest.net: 8.21Mbps down 510kbps up

    \
     
     \ /
      Last update: 2018-05-08 13:54    [W:4.102 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site