Messages in this thread | | | Subject | Re: [PATCH 1/2] dt-bindings: leds: Add SC27xx breathing light controller documentation | From | Jacek Anaszewski <> | Date | Mon, 7 May 2018 22:13:21 +0200 |
| |
Hi Baolin,
Thank you for the patch. Please find few notes below.
On 05/04/2018 12:08 PM, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27xx series > breathing light controller, which supports 3 outputs: red LED, green > LED and blue LED. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > .../devicetree/bindings/leds/leds-sc27xx-bltc.txt | 39 ++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt > new file mode 100644 > index 0000000..d4e267d > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt > @@ -0,0 +1,39 @@ > +LEDs connected to Spreadtrum SC27XX PMIC breathing light controller > + > +The SC27xx breathing light controller supports to 3 outputs: > +red LED, green LED and blue LED. Each LED can work at normal > +PWM mode or breath light mode. > + > +Required properties: > +- compatible: should be "sprd,sc27xx-bltc".
s/should/Should/
> +- #address-cells: must be 1.
s/must/Must/
> +- #size-cells: must be 0.
Ditto.
> +- reg: specify controller address.
s/specify/Specify/
> + > +LED sub-node properties: > +- reg: number of LED line (could be from 0 to 2).
s/number/Number/
> +- label: (optional) name of LED.
- label: see Documentation/devicetree/bindings/leds/common.txt
> + > +Examples: > + > +led-controller@200 { > + compatible = "sprd,sc27xx-bltc"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x200>; > + > + red@0 {
s/red/led/
> + label = "red"; > + reg = <0x0>; > + }; > + > + green@1 {
s/green/led/
> + label = "green"; > + reg = <0x1>; > + }; > + > + blue@2 {
s/blue/led/
> + label = "blue"; > + reg = <0x2>; > + }; > +}; >
-- Best regards, Jacek Anaszewski
| |