lkml.org 
[lkml]   [2018]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional
    On Thu,  3 May 2018 17:50:30 +0530
    Abhishek Sahu <absahu@codeaurora.org> wrote:

    > Now, nand-ecc-strength is optional. If specified in DT, then
    > controller will use this ECC strength otherwise ECC strength will
    > be calculated according to chip requirement and available OOB size.
    >
    > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
    > ---
    > * Changes from v1:
    >
    > NEW PATCH
    >
    > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > index 73d336be..f246aa0 100644
    > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > @@ -45,11 +45,13 @@ Required properties:
    > number (e.g., 0, 1, 2, etc.)
    > - #address-cells: see partition.txt
    > - #size-cells: see partition.txt
    > -- nand-ecc-strength: see nand.txt
    > - nand-ecc-step-size: must be 512. see nand.txt for more details.

    As mentioned in my other review, no need to specify nand-ecc-step-size
    if you don't have a choice. You can remove the property and say that
    nand-ecc-strength encodes the ECC strength for 512 bytes chunks.

    >
    > Optional properties:
    > - nand-bus-width: see nand.txt
    > +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will
    > + be used according to chip requirement and available
    > + OOB size.
    >
    > Each nandcs device node may optionally contain a 'partitions' sub-node, which
    > further contains sub-nodes describing the flash partition mapping. See

    \
     
     \ /
      Last update: 2018-05-07 10:40    [W:4.122 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site