Messages in this thread |  | | Date | Sat, 5 May 2018 11:29:11 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] locking/atomics: Clean up the atomic.h maze of #defines |
| |
On Sat, May 05, 2018 at 11:09:03AM +0200, Ingo Molnar wrote: > > > # ifndef atomic_fetch_dec_acquire > > > # define atomic_fetch_dec_acquire(...) __atomic_op_acquire(atomic_fetch_dec, __VA_ARGS__) > > > # endif > > > # ifndef atomic_fetch_dec_release > > > # define atomic_fetch_dec_release(...) __atomic_op_release(atomic_fetch_dec, __VA_ARGS__) > > > # endif > > > # ifndef atomic_fetch_dec > > > # define atomic_fetch_dec(...) __atomic_op_fence(atomic_fetch_dec, __VA_ARGS__) > > > # endif > > > #endif > > > > > > The new variant is readable at a glance, and the hierarchy of defines is very > > > obvious as well. > > > > It wraps and looks hideous in my normal setup. And I do detest that indent > > after # thing. > > You should use wider terminals if you take a look at such code - there's already > numerous areas of the kernel that are not readable on 80x25 terminals. > > _Please_ try the following experiment, for me: > > Enter the 21st century temporarily and widen two of your terminals from 80 cols to > 100 cols - it's only ~20% wider.
Doesn't work that way. The only way I get more columns is if I shrink my font further. I work with tiles per monitor (left/right obv.) and use two columns per editor. This gets me a total of 4 columns.
On my desktop that is slightly over 100 characters per column, on my laptop that is slightly below 100 -- mostly because I'm pixel limited on fontsize on that thing (FullHD sucks).
If it wraps it wraps.
|  |