Messages in this thread | | | Date | Sat, 5 May 2018 08:51:43 +0200 | From | Danny Milosavljevic <> | Subject | Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls |
| |
Hi Maxime,
On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before?
Yes. However Chen-Yu said that except for debugfs that cannot be observed by user space anyway.
It's nice to have the NEW controls have multiple channels, which is what this does.
>And also, wouldn't > the controls be called "Left Mixer Left Mixer Left DAC Playback > Switch" (for the first one) now?
No. I checked using "amixer" - the names look fine, "Left Mixer Left DAC Playback Switch".
With the patch series, amixer says:
numid=10,iface=MIXER,name='FM Playback Switch' numid=6,iface=MIXER,name='FM Playback Volume' numid=5,iface=MIXER,name='Line Boost Volume' numid=9,iface=MIXER,name='Line Playback Switch' numid=4,iface=MIXER,name='Line Playback Volume' numid=1,iface=MIXER,name='Mic1 Boost Volume' numid=11,iface=MIXER,name='Mic1 Playback Switch' numid=2,iface=MIXER,name='Mic2 Boost Volume' numid=12,iface=MIXER,name='Mic2 Playback Switch' numid=7,iface=MIXER,name='Mic Playback Volume' numid=18,iface=MIXER,name='Capture Source' numid=19,iface=MIXER,name='Differential Line Source' numid=8,iface=MIXER,name='Left Mixer Left DAC Playback Switch' numid=15,iface=MIXER,name='Power Amplifier DAC Playback Switch' numid=16,iface=MIXER,name='Power Amplifier Mixer Playback Switch' numid=17,iface=MIXER,name='Power Amplifier Mute Switch' numid=3,iface=MIXER,name='Power Amplifier Volume' numid=14,iface=MIXER,name='Right Mixer Left DAC Playback Switch' numid=13,iface=MIXER,name='Right Mixer Right DAC Playback Switch' [unhandled content-type:application/pgp-signature] | |