lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/24] selftests: locking: return Kselftest Skip code for skipped tests
    Date
    When locking test is skipped because of unmet dependencies and/or
    unsupported configuration, it exits with error which is treated as
    a fail by the Kselftest framework. This leads to false negative
    result even when the test could not be run.

    Change it to return kselftest skip code when a test gets skipped to
    clearly report that the test could not be run.

    Added an explicit search for ww_mutex module and return skip code if
    it isn't found to differentiate between the failure to load the module
    condition and module not found condition.

    Kselftest framework SKIP code is 4 and the framework prints appropriate
    messages to indicate that the test is skipped.

    Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
    ---
    tools/testing/selftests/locking/ww_mutex.sh | 8 ++++++++
    1 file changed, 8 insertions(+)
    mode change 100644 => 100755 tools/testing/selftests/locking/ww_mutex.sh

    diff --git a/tools/testing/selftests/locking/ww_mutex.sh b/tools/testing/selftests/locking/ww_mutex.sh
    old mode 100644
    new mode 100755
    index 2c3d6b1878c2..91e4ac7566af
    --- a/tools/testing/selftests/locking/ww_mutex.sh
    +++ b/tools/testing/selftests/locking/ww_mutex.sh
    @@ -1,6 +1,14 @@
    #!/bin/sh
    # SPDX-License-Identifier: GPL-2.0
    +
    +# Kselftest framework requirement - SKIP code is 4.
    +ksft_skip=4
    +
    # Runs API tests for struct ww_mutex (Wait/Wound mutexes)
    +if ! /sbin/modprobe -q -n test-ww_mutex; then
    + echo "ww_mutex: module test-ww_mutex is not found [SKIP]"
    + exit $ksft_skip
    +fi

    if /sbin/modprobe -q test-ww_mutex; then
    /sbin/modprobe -q -r test-ww_mutex
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-05-05 03:18    [W:2.227 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site