lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization
    Hi,

    On Wed, May 2, 2018 at 2:06 PM, Manu Gautam <mgautam@codeaurora.org> wrote:
    > QMP PHY for USB/PCIE requires pipe_clk for locking of
    > retime buffers at the pipe interface. Driver checks for
    > PHY_STATUS without enabling pipe_clk due to which
    > phy_init() fails with initialization timeout.
    > Though pipe_clk is output from PHY (after PLL is programmed
    > during initialization sequence) to GCC clock_ctl and then fed
    > back to PHY but for PHY_STATUS register to reflect successful
    > initialization pipe_clk from GCC must be present.
    > Since, clock driver now ignores status_check for pipe_clk on
    > clk_enable/disable, driver can safely enable/disable pipe_clk
    > from phy_init/exit.
    >
    > Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
    > ---
    > drivers/phy/qualcomm/phy-qcom-qmp.c | 22 ++++++++--------------
    > 1 file changed, 8 insertions(+), 14 deletions(-)

    Given the agreement with Stephen Boyd that we'll just BRANCH_HALT_SKIP
    for now, this all looks good to me.

    Reviewed-by: Douglas Anderson <dianders@chromium.org>

    \
     
     \ /
      Last update: 2018-05-04 21:47    [W:4.391 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site