Messages in this thread | | | Date | Fri, 04 May 2018 13:37:33 -0400 (EDT) | Subject | Re: [PATCH 1/4] alim15x3: move irq-restore before pci_dev_put() | From | David Miller <> |
| |
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Fri, 4 May 2018 16:24:43 +0200
> init_chipset_ali15x3() initializes the chipset during init with disabled > interrupts. There is no need to keep the interrupts disabled during > pci_dev_put(). > Move the irq-restore before pci_dev_put() is invoked. > > Side note: The same init is performed in > drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts. > It looks that the same hardware is supported in the ATA land. Would it > make sense to remove this driver since it is supported in the other > subsystem? > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: David S. Miller <davem@davemloft.net>
| |