lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] ftrace: Have set_graph_* files have normal file modes
    From: Chen LinX <linx.z.chen@intel.com>

    The set_graph_function and set_graph_notrace file mode should be 0644
    instead of 0444 as they are writeable. Note, the mode appears to be ignored
    regardless, but they should at least look sane.

    Link: http://lkml.kernel.org/r/1409725869-4501-1-git-send-email-linx.z.chen@intel.com

    Acked-by: Namhyung Kim <namhyung@kernel.org>
    Signed-off-by: Chen LinX <linx.z.chen@intel.com>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    ---
    kernel/trace/ftrace.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
    index 16bbf062018f..8d83bcf9ef69 100644
    --- a/kernel/trace/ftrace.c
    +++ b/kernel/trace/ftrace.c
    @@ -5514,10 +5514,10 @@ static __init int ftrace_init_dyn_tracefs(struct dentry *d_tracer)
    ftrace_create_filter_files(&global_ops, d_tracer);

    #ifdef CONFIG_FUNCTION_GRAPH_TRACER
    - trace_create_file("set_graph_function", 0444, d_tracer,
    + trace_create_file("set_graph_function", 0644, d_tracer,
    NULL,
    &ftrace_graph_fops);
    - trace_create_file("set_graph_notrace", 0444, d_tracer,
    + trace_create_file("set_graph_notrace", 0644, d_tracer,
    NULL,
    &ftrace_graph_notrace_fops);
    #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
    --
    2.17.0

    \
     
     \ /
      Last update: 2018-05-04 17:54    [W:3.146 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site