lkml.org 
[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] kselftests: fix ptr_ret.cocci warnings
From: kbuild test robot <fengguang.wu@intel.com>

lib/test_atomic_sections.c:66:1-3: WARNING: PTR_ERR_OR_ZERO can be used


Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 3b0e47f0ade1 ("kselftests: Add tests for the preemptoff and irqsoff tracers")
CC: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

test_atomic_sections.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

--- a/lib/test_atomic_sections.c
+++ b/lib/test_atomic_sections.c
@@ -63,10 +63,7 @@ static int __init atomic_sect_init(void)
snprintf(task_name, 50, "%s dis test", atomic_mode);

test_task = kthread_run((void*)atomic_sect_run, NULL, task_name);
- if (IS_ERR(test_task))
- return PTR_ERR(test_task);
-
- return 0;
+ return PTR_ERR_OR_ZERO(test_task);
}

static void __exit atomic_sect_exit(void)
\
 
 \ /
  Last update: 2018-05-31 08:49    [W:0.135 / U:0.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site