Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 31 May 2018 22:15:45 +0300 | Subject | Re: [PATCH] aic94xx: set error code on an error path in aic94xx_init |
| |
On Thu, May 31, 2018 at 9:28 PM, Peter Melnichenko <melnichenko@ispras.ru> wrote: > When sas_domain_attach_transport returns NULL, aic94xx_init > frees acquired resources but returns err equal to 0, as > assigned by a previous statement. > > The patch sets err to -ENOMEM before jumping to the error label.
Wouldn't be better to fix a callee to return proper error code and...
> aic94xx_transport_template = > sas_domain_attach_transport(&aic94xx_transport_functions); > - if (!aic94xx_transport_template) > + if (!aic94xx_transport_template) { > + err = -ENOMEM; > goto out_destroy_caches; > + }
this becomes
err = _attach_(); if (err < 0) goto ; _template = err;
?
-- With Best Regards, Andy Shevchenko
| |