Messages in this thread | | | Date | Fri, 01 Jun 2018 00:36:54 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH 2/2] powerpc: Add support for function error injection |
| |
Michael Ellerman wrote: > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes: > >> Michael Ellerman wrote: >>> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes: >>>> ... >>> >>> A change log is always nice even if it's short :) >> >> I tried, but really couldn't come up with anything more to write. I'll >> try harder for v2 :) > > Yeah true. > > You could just say "All that's required is to define x and y and select > the Kconfig symbol".
Ok, sure.
> >>> This looks fine to me, it's probably easiest if it goes in via tip along >>> with patch 1. >>> >>> Acked-by: Michael Ellerman <mpe@ellerman.id.au> >> >> Thanks for the review. I'll base v2 on -tip > > I guess if it doesn't already apply to tip you should rebase it. You've > probably missed 4.18 anyway.
Oh ok. I just tried and it seems to apply just fine. I'll post v2 after giving this a quick test.
- Naveen
| |