lkml.org 
[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] two more s390 bug fixes for 4.17
On Wed, May 30, 2018 at 11:11:40AM +0200, Martin Schwidefsky wrote:
> On Wed, 30 May 2018 00:41:30 -0700
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > > - req->completion_data = cqr;
> > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr;
> > > +
> >
> > Please don't play such tricks. In general your driver structure
> > should have struct request embedded. If for some reason
> > struct dasd_ccw_req has a different life time please create a new
> > structure instead of these hacks.
>
> Why do you consider this to be a 'trick'? The blk_mq_rq_to_pdu is
> meant to be used to access a block of data that is is associated
> with a request, no? With the change we store a single value, the
> pointer to a struct dasd_ccw_req. The struct request comes first,
> later do_dasd_request creates the struct dasd_ccw_req with the
> CCW chain for the request. And for the blk timeout handler we need
> a way to find the dasd_ccw_req again.

We'll we try really hard to have a structure that we can use
container_of on. At least a minimal container with just the pointer
for a quick fix, but in general it seems like you should be able
to allocate the whole dasd_ccw_req with the request and just initialize
it later.

\
 
 \ /
  Last update: 2018-05-31 18:14    [W:0.112 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site