Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: Can printk() sleep at runtime? | Date | Thu, 31 May 2018 08:19:49 -0700 |
| |
Quoting Linus Torvalds (2018-05-31 07:32:10) > On Thu, May 31, 2018 at 5:05 AM Petr Mladek <pmladek@suse.com> wrote: > > > > Anyway, we need to fix or remove this format. vsprintf-like functions > > are called in any context and nobody expect that they might sleep. > > Ack. I guess the argument is that "%pCr" is rare, and none of *those* > users may care, but I do think that doing things wrong as-is. > > It's too subtle to have to know you're in a particular locking context > when you use a particular %p modifier. >
Agreed. Removing the format seems to be the best approach. It looks like only Geert has used it in the last few years and it hasn't been used much otherwise.
| |