Messages in this thread | | | Subject | Re: [PATCH 4/5] nvmet: use atomic allocations when allocating fc requests | From | Sagi Grimberg <> | Date | Thu, 31 May 2018 12:31:29 +0300 |
| |
> diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c > index 34712def81b1..d2209c60f95f 100644 > --- a/drivers/nvme/target/fcloop.c > +++ b/drivers/nvme/target/fcloop.c > @@ -509,7 +509,7 @@ fcloop_fcp_req(struct nvme_fc_local_port *localport, > if (!rport->targetport) > return -ECONNREFUSED; > > - tfcp_req = kzalloc(sizeof(*tfcp_req), GFP_KERNEL); > + tfcp_req = kzalloc(sizeof(*tfcp_req), GFP_ATOMIC);
Question, why isn't tfcp_req embedded in fcpreq? don't they have the same lifetime?
> if (!tfcp_req) > return -ENOMEM; > >
| |