Messages in this thread | | | Subject | Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT | From | Vladimir Zapolskiy <> | Date | Thu, 31 May 2018 11:54:04 +0300 |
| |
Hi Clément,
On 05/31/2018 11:41 AM, Clément Péron wrote: > Hi Vladimir, > > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy > <vladimir_zapolskiy@mentor.com> wrote: >> >> On 05/30/2018 03:03 PM, Clément Péron wrote: >>> From: Colin Didier <colin.didier@devialet.com> >>> >>> Add missing compatible and clock properties for EPIT node. >>> >>> Signed-off-by: Colin Didier <colin.didier@devialet.com> >>> Signed-off-by: Clément Peron <clement.peron@devialet.com> >>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> >>> --- >>> arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi >>> index c003e62bf290..0feec516847a 100644 >>> --- a/arch/arm/boot/dts/imx6qdl.dtsi >>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi >>> @@ -844,13 +844,23 @@ >>> }; >>> >>> epit1: epit@20d0000 { /* EPIT1 */ >> >> epit1: timer@20d0000 { ... >> >> And /* EPIT1 */ comment can be removed, it is quite clear from the same >> line context. >> >> Formally it is a subject to another patch, but I think this can be >> accepted as a part of this one. > > Should I also update other boards ? > I only did it for imx6qdl.dtsi, but the EPIT is present in other boards > but i can't test it myself. >
Sure, please do it, why not, it is quite a safe modification.
One change per one dtsi file will suffice, and I see that imx25.dtsi already contains the requested change, however probably you may want to update its compatible = "fsl,imx25-epit" line.
Regarding compatibles for other imx6* SoCs, I think all of them should be documented in fsl,imxepit.txt and then added to the correspondent dtsi files one per SoC.
And I forgot the outcome of one former discussion with Uwe Kleine-König, but if my bad memory serves me, we agreed that i.MX25 was released later than i.MX31, so the most generic (the last value in the list) compatible should be a compatible with i.MX31 like in
imx25.dtsi:367: compatible = "fsl,imx25-gpt", "fsl,imx31-gpt";
-- With best wishes, Vladimir
| |