lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet
    Hi Greg,

    On Wed, May 30, 2018 at 2:28 AM, Greg Ungerer <gerg@linux-m68k.org> wrote:
    > On 28/05/18 20:15, Geert Uytterhoeven wrote:
    >> On Mon, May 28, 2018 at 7:26 AM, Finn Thain <fthain@telegraphics.com.au>
    >> wrote:
    >>> On Mon, 28 May 2018, Michael Schmitz wrote:
    >>>> Am 27.05.2018 um 17:49 schrieb Finn Thain:
    >>>>> On Sun, 27 May 2018, Michael Schmitz wrote:
    >>>>>> That should have fixed the warning already ...
    >>>>>
    >>>>> It's still not fixed (hence my "acked-by" for Geunter's patch).
    >>>>
    >>>> Odd - does link order still matter even though the
    >>>> arch_setup_dev_archdata() function from the core platform code is
    >>>> declared as a weak symbol?
    >>>>
    >>>> I'll see what I can find out on elgar ...
    >>>
    >>> Any one of the numerous patches/rfcs/suggestions that I sent will avoid
    >>> the WARN splat.
    >>>
    >>> When I said "it's still not fixed", what I meant to say was, "it's still
    >>> not fixed in mainline and no proposed fix was accepted to the best of my
    >>> knowledge".
    >>
    >> Indeed.
    >>
    >> Do we have a consensus on the way forward? The merge window for
    >> v4.18 will open soon.
    >
    > For whatever it is worth I thought Finn's patch was the best approach
    > (https://lkml.org/lkml/2018/5/17/333, "m68k: Set default dma mask for
    > platform device").

    FTR: done.

    > We seem to be hitting quite a few places (within m68k) that otherwise
    > need individual fixes. There is no immediate need to revert existing
    > changes that have already been applied if we use this now either
    > (like my FEC fix, commit f61e64310b75 "m68k: set dma and coherent
    > masks for platform FEC ethernets").

    Indeed.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2018-05-30 21:56    [W:2.281 / U:2.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site