Messages in this thread | | | Subject | Re: [PATCH 6/6] mfd: da9063: Add DA9063L support | From | Marek Vasut <> | Date | Wed, 30 May 2018 13:26:03 +0200 |
| |
On 05/29/2018 09:46 AM, Lee Jones wrote: > On Thu, 24 May 2018, Marek Vasut wrote: >> On 05/24/2018 02:32 PM, Steve Twiss wrote: >>> On 24 May 2018 @ 12:49 Steve Twiss wrote: > > [...] > >>> static const struct regmap_irq da9063l_irqs[] = { >>> /* DA9063 event A register */ >>> [DA9063L_IRQ_ONKEY] = { >>> .reg_offset = DA9063_REG_EVENT_A_OFFSET, >>> .mask = DA9063_M_ONKEY, >>> }, > > [...] > >>> [DA9063L_IRQ_GPI15] = { >>> .reg_offset = DA9063_REG_EVENT_D_OFFSET, >>> .mask = DA9063_M_GPI15, >>> }, >>> }; >> >> We can probably do the same trick with the regmaps and irqmaps as with >> the rest, that is, reorder them and register only a smaller portion ? > > Please also consider using REGMAP_IRQ_REG().
Done in a new separate patch with a simple sed oneliner
sed -i "/\[DA9063_IRQ_/ {N;N;N;s/\n//g;s/.*\[\(DA9063_IRQ_[^]]\+\)].*reg_offset = \([^,]\+\),.* = \([^,]\+\),.*/\tREGMAP_IRQ_REG(\1, \2, \3),/}" drivers/mfd/da9063-irq.c
-- Best regards, Marek Vasut
| |