lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 024/153] cdrom: information leak in cdrom_ioctl_media_changed()
    3.2.102-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 9de4ee40547fd315d4a0ed1dd15a2fa3559ad707 upstream.

    This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned
    long. The way the check is written now, if one of the high 32 bits is
    set then we could read outside the info->slots[] array.

    This bug is pretty old and it predates git.

    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/cdrom/cdrom.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/cdrom/cdrom.c
    +++ b/drivers/cdrom/cdrom.c
    @@ -2342,7 +2342,7 @@ static int cdrom_ioctl_media_changed(str
    if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
    return media_changed(cdi, 1);

    - if ((unsigned int)arg >= cdi->capacity)
    + if (arg >= cdi->capacity)
    return -EINVAL;

    info = kmalloc(sizeof(*info), GFP_KERNEL);
    \
     
     \ /
      Last update: 2018-05-30 13:17    [W:3.091 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site