Messages in this thread | | | Date | Thu, 3 May 2018 14:20:33 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/1] watchdog: hpwdt: Claim NMIs generated by iLO5 |
| |
On Thu, May 03, 2018 at 03:00:55PM -0600, Jerry Hoemann wrote: > On iLO5 going forward we want to return and not claim the NMI, if > the NMI was NOT gnerated by the iLO as a result of the watchdog > timing out or an explicit generate NMI. > > The sense of the test in is inverted and prevents hpwdt_pretimeout > from claiming NMIs when it should. > > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Fixes: a042229a18ac ("watchdog: hpwdt: Update nmi_panic message.") Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index a43ab2cecca2..9dc62a461451 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -159,7 +159,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) > "3. OA Forward Progress Log\n" > "4. iLO Event Log"; > > - if (ilo5 && ulReason == NMI_UNKNOWN && mynmi) > + if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi) > return NMI_DONE; > > if (ilo5 && !pretimeout) > -- > 2.13.6 >
| |