[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: dm-writecache: fix compilation issue with !DAX
On Tue, May 29 2018 at  1:52pm -0400,
Ross Zwisler <> wrote:

> As reported by Arnd (, dm-writecache
> will fail with link errors in configs where DAX isn't present:
> drivers/md/dm-writecache.o: In function `writecache_ctr':
> dm-writecache.c:(.text+0x1fdc): undefined reference to `dax_read_lock'
> dm-writecache.c:(.text+0x2004): undefined reference to `dax_direct_access'
> dm-writecache.c:(.text+0x21cc): undefined reference to `dax_read_unlock'
> Fix this by following the lead of the other DM modules and wrapping calls
> to the generic DAX code in #if IS_ENABLED(CONFIG_DAX_DRIVER) blocks.
> We also expand the failure case for the 'p' (persistent memory) flag so
> that fails on both architectures that don't support persistent memory and
> on kernels that don't have DAX support configured. This prevents us from
> ever hitting the BUG() in the persistent_memory_claim() stub.
> Signed-off-by: Ross Zwisler <>
> Reported-by: Arnd Bergmann <>

Thanks, I've picked this up.


 \ /
  Last update: 2018-05-29 20:09    [W:0.149 / U:26.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site