lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 06/20] signal: drop else branch in do_signal_stop()
I am busy now, can't review, just picked a random patch from this series...

On 05/28, Christian Brauner wrote:
> do_signal_stop() already returns in the if branch so there's no need to
> keep the else branch around.

OK, but for what???

Do you think this change makes the code more readable? more clean? or what?

I do not really care but to me these "if/else" branches make this code more
symmetrical, so I don't understand the purpose.



> Signed-off-by: Christian Brauner <christian@brauner.io>
> ---
> v0->v1:
> * patch unchanged
> ---
> kernel/signal.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index a628b56415e6..d1914439f144 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2214,14 +2214,14 @@ static bool do_signal_stop(int signr)
> /* Now we don't run again until woken by SIGCONT or SIGKILL */
> freezable_schedule();
> return true;
> - } else {
> - /*
> - * While ptraced, group stop is handled by STOP trap.
> - * Schedule it and let the caller deal with it.
> - */
> - task_set_jobctl_pending(current, JOBCTL_TRAP_STOP);
> - return false;
> }
> +
> + /*
> + * While ptraced, group stop is handled by STOP trap.
> + * Schedule it and let the caller deal with it.
> + */
> + task_set_jobctl_pending(current, JOBCTL_TRAP_STOP);
> + return false;
> }
>
> /**
> --
> 2.17.0
>

\
 
 \ /
  Last update: 2018-05-29 16:31    [W:0.127 / U:2.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site