lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock
From
Date


On 5/26/18 4:45 AM, Wei Yongjun wrote:

> The function alloc_dma_buffer() is called from ibmvmc_add_buffer(),
> in which a spin lock be held here, so we should use GFP_ATOMIC when
> a lock is held.
>
> Fixes: 0eca353e7ae7 ("misc: IBM Virtual Management Channel Driver (VMC)")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/misc/ibmvmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
> index fb83d13..8f82bb9 100644
> --- a/drivers/misc/ibmvmc.c
> +++ b/drivers/misc/ibmvmc.c
> @@ -273,7 +273,7 @@ static void *alloc_dma_buffer(struct vio_dev *vdev, size_t size,
> dma_addr_t *dma_handle)
> {
> /* allocate memory */
> - void *buffer = kzalloc(size, GFP_KERNEL);
> + void *buffer = kzalloc(size, GFP_ATOMIC);
>
> if (!buffer) {
> *dma_handle = 0;
>
Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>

\
 
 \ /
  Last update: 2018-05-29 16:17    [W:0.036 / U:2.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site