lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 net-next 2/2] tcp: minor optimization around tcp_hdr() usage in tcp receive path
From
Date


On 05/28/2018 05:41 PM, Yafang Shao wrote:

> OK.
>
> And what about introducing a new helper tcp_hdr_fast() ?
>
> /* use it when tcp header has not been pulled yet */
> static inline struct tcphdr *tcp_hdr_fast(const struct sk_buff *skb)
>
> {
>
> return (const struct tcphdr *)skb->data;
>
> }
>
>
> That could help us to use this optimized one instead of the original
> one if possilbe.


I would rather not add such macro...

The call site needs to know what is going on, so having a macro like that would not help.

\
 
 \ /
  Last update: 2018-05-29 06:54    [W:0.037 / U:1.620 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site