lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/19] serdev: Allows dynamic creation of devices via sysfs
Hi Andy,

On Tue, May 29, 2018 at 10:35 PM Andy Shevchenko <andy.shevchenko@gmail.com>
wrote:

> On Tue, May 29, 2018 at 4:10 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
> > Allow creating and deleting devices via sysfs. Devices created will be
> > matched to serdev drivers via modalias (the string provided by the user)
> > and deleted via their name.

> > + int err;
> > + char *nline;

> Better to read in reversed order.

> > + nline = strchr(buf, '\n');
> > + if (nline)
> > + *nline = '\0';

> strim() / strstrip() ?

> > + nline = strchr(buf, '\n');
> > + if (nline)
> > + *nline = '\0';

> Ditto.

> > +static DEVICE_ATTR_IGNORE_LOCKDEP(delete_device, 0200, NULL,
> > + delete_device_store);

> Perhaps leave it on one line?

> --
> With Best Regards,
> Andy Shevchenko

Thanks for your review. I am working on v2 at
https://github.com/ribalda/linux/tree/serdev2 it fixes your comments except
the line cut for DEVICE_ATTR, I want also to make checkpatch happy ;)

Will send v2 to the list after I got more feedback, you can of course ping
me if there is something in my tree that it is not fixed properly.

Cheers


--
Ricardo Ribalda

\
 
 \ /
  Last update: 2018-05-29 23:25    [W:0.083 / U:23.636 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site