lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/19] serdev: Allows dynamic creation of devices via sysfs
On Tue, May 29, 2018 at 4:10 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Allow creating and deleting devices via sysfs. Devices created will be
> matched to serdev drivers via modalias (the string provided by the user)
> and deleted via their name.

> + int err;
> + char *nline;

Better to read in reversed order.

> + nline = strchr(buf, '\n');
> + if (nline)
> + *nline = '\0';

strim() / strstrip() ?

> + nline = strchr(buf, '\n');
> + if (nline)
> + *nline = '\0';

Ditto.

> +static DEVICE_ATTR_IGNORE_LOCKDEP(delete_device, 0200, NULL,
> + delete_device_store);

Perhaps leave it on one line?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-05-29 22:36    [W:0.188 / U:7.640 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site