lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 085/272] platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 0e5b09b165510e2ea5c526e962c4edadd849ef4c ]

    We're freeing "value_name" which is NULL, so that's a no-op, but we
    intended to free "location_name" instead. And then we don't free the
    names in token_location_attrs[0] and token_value_attrs[0].

    Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/x86/dell-smbios-base.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/platform/x86/dell-smbios-base.c
    +++ b/drivers/platform/x86/dell-smbios-base.c
    @@ -514,7 +514,7 @@ static int build_tokens_sysfs(struct pla
    continue;

    loop_fail_create_value:
    - kfree(value_name);
    + kfree(location_name);
    goto out_unwind_strings;
    }
    smbios_attribute_group.attrs = token_attrs;
    @@ -525,7 +525,7 @@ loop_fail_create_value:
    return 0;

    out_unwind_strings:
    - for (i = i-1; i > 0; i--) {
    + while (i--) {
    kfree(token_location_attrs[i].attr.name);
    kfree(token_value_attrs[i].attr.name);
    }

    \
     
     \ /
      Last update: 2018-05-28 13:54    [W:4.267 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site