Messages in this thread | | | From | Michael Schmitz <> | Date | Tue, 29 May 2018 07:59:37 +1200 | Subject | Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet |
| |
Hi Geert,
my preference would be Finn's patch introducing a m68k arch_setup_pdev_archdata(). It nicely preserves what bus code sets up prior to registering a platform device (important for Zorro devices using platform or mfd devices), and allows overriding by drivers that need it.
If ever a kernel-wide consensus is reached to move this setup to the generic arch_setup_pdev_archdata(), we can still back out his patch at that time. Finn found one counterexample where absence of DMA mask signaled 'do not use DMA', so I think moving the DMA mask setup to generic code is unlikely to happen any time.
Just my $0.02 ...
Cheers,
MIchael
On Mon, May 28, 2018 at 10:15 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, May 28, 2018 at 7:26 AM, Finn Thain <fthain@telegraphics.com.au> wrote: >> On Mon, 28 May 2018, Michael Schmitz wrote: >>> Am 27.05.2018 um 17:49 schrieb Finn Thain: >>> > On Sun, 27 May 2018, Michael Schmitz wrote: >>> > >>> >> That should have fixed the warning already ... >>> > >>> > It's still not fixed (hence my "acked-by" for Geunter's patch). >>> > >>> >>> Odd - does link order still matter even though the >>> arch_setup_dev_archdata() function from the core platform code is >>> declared as a weak symbol? >>> >>> I'll see what I can find out on elgar ... >>> >> >> Any one of the numerous patches/rfcs/suggestions that I sent will avoid >> the WARN splat. >> >> When I said "it's still not fixed", what I meant to say was, "it's still >> not fixed in mainline and no proposed fix was accepted to the best of my >> knowledge". > > Indeed. > > Do we have a consensus on the way forward? The merge window for > v4.18 will open soon. > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |