Messages in this thread | | | From | Guenter Roeck <> | Date | Fri, 25 May 2018 06:20:50 -0700 | Subject | Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files |
| |
On Fri, May 25, 2018 at 2:04 AM Lin, Mengdong <mengdong.lin@intel.com> wrote:
> > -----Original Message----- > > From: alsa-devel-bounces@alsa-project.org [mailto: alsa-devel-bounces@alsa- > > project.org] On Behalf Of Mark Brown > > Sent: Thursday, May 24, 2018 11:12 PM
> > On Thu, May 24, 2018 at 07:55:06AM -0700, Guenter Roeck wrote: > > > On Thu, May 24, 2018 at 7:18 AM Mark Brown <broonie@kernel.org> wrote: > > > > Your mail client formatting seems to be broken, the word wrapping is really > > funky (it looks like it's breaking longer than 80 column lines in the middle of > > paragraphs rather than flowing paragraphs within 80 columns). > >
gmail. Teaches me to not send any patches from my corporate acccount; it is all but impossible to teach gmail to leave formatting alone.
> Please put the Skylake specific structures in a separate header file, not in asoc.h.
> The file asoc.h is for generic topology structures which are platform independent. The topology code in alsa-lib never parses the platform specific structures.
> The Skylake specific structures are needed by vendor applications like Intel topology tool (ITT) to define topology for different platforms. The applications can include both asoc.h, skl-tplg-interface.h and other device specific headers.
https://patchwork.kernel.org/patch/10425395/ https://patchwork.kernel.org/patch/10425393/ https://patchwork.kernel.org/patch/10425387/
should hopefully be along that line.
Thanks, Guenter
| |