lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 003/165] net/sched: fix refcnt leak in the error path of tcf_vlan_init()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Davide Caratti <dcaratti@redhat.com>

    [ Upstream commit 5a4931ae0193f8a4a97e8260fd0df1d705d83299 ]

    Similarly to what was done with commit a52956dfc503 ("net sched actions:
    fix refcnt leak in skbmod"), fix the error path of tcf_vlan_init() to avoid
    refcnt leaks when wrong value of TCA_VLAN_PUSH_VLAN_PROTOCOL is given.

    Fixes: 5026c9b1bafc ("net sched: vlan action fix late binding")
    CC: Roman Mashak <mrv@mojatatu.com>
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/act_vlan.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/sched/act_vlan.c
    +++ b/net/sched/act_vlan.c
    @@ -154,6 +154,8 @@ static int tcf_vlan_init(struct net *net
    case htons(ETH_P_8021AD):
    break;
    default:
    + if (exists)
    + tcf_idr_release(*a, bind);
    return -EPROTONOSUPPORT;
    }
    } else {

    \
     
     \ /
      Last update: 2018-05-24 13:27    [W:4.092 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site