lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 027/165] hv_netvsc: disable NAPI before channel close
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stephen Hemminger <stephen@networkplumber.org>

    [ Commit 8348e0460ab1473f06c8b824699dd2eed3c1979d upstream. ]

    This makes sure that no CPU is still process packets when
    the channel is closed.

    Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal")
    Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/hyperv/netvsc.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/net/hyperv/netvsc.c
    +++ b/drivers/net/hyperv/netvsc.c
    @@ -567,6 +567,10 @@ void netvsc_device_remove(struct hv_devi

    RCU_INIT_POINTER(net_device_ctx->nvdev, NULL);

    + /* And disassociate NAPI context from device */
    + for (i = 0; i < net_device->num_chn; i++)
    + netif_napi_del(&net_device->chan_table[i].napi);
    +
    /*
    * At this point, no one should be accessing net_device
    * except in here
    @@ -578,10 +582,6 @@ void netvsc_device_remove(struct hv_devi

    netvsc_teardown_gpadl(device, net_device);

    - /* And dissassociate NAPI context from device */
    - for (i = 0; i < net_device->num_chn; i++)
    - netif_napi_del(&net_device->chan_table[i].napi);
    -
    /* Release all resources */
    free_netvsc_device_rcu(net_device);
    }

    \
     
     \ /
      Last update: 2018-05-24 13:22    [W:4.023 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site