Messages in this thread | | | Date | Thu, 24 May 2018 21:52:25 -0400 (EDT) | Subject | Re: [PATCH net-next] cxgb4: Check for kvzalloc allocation failure | From | David Miller <> |
| |
From: YueHaibing <yuehaibing@huawei.com> Date: Fri, 25 May 2018 09:39:20 +0800
> On 2018/5/24 23:07, David Miller wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> Date: Tue, 22 May 2018 15:07:18 +0800 >> >>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> index 130d1ee..019cffe 100644 >>> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> @@ -4135,6 +4135,10 @@ static int adap_init0(struct adapter *adap) >>> * card >>> */ >>> card_fw = kvzalloc(sizeof(*card_fw), GFP_KERNEL); >>> + if (!card_fw) { >>> + ret = -ENOMEM; >>> + goto bye; >>> + } >>> >> >> On error, this leaks fw_info. > > Hi David, > > I checked fw_info is an element of fw_info_array,there all members of struct fw_info no need free.
Aha, I misread the code, sorry.
Applied, thanks.
| |