Messages in this thread | | | Subject | Re: [PATCH v3] usbip: dynamically allocate idev by nports found in sysfs | From | Shuah Khan <> | Date | Wed, 23 May 2018 10:44:57 -0600 |
| |
On 05/23/2018 03:22 AM, Michael Grzeschik wrote: > As the amount of available ports varies by the kernels build > configuration. To remove the limitation of the fixed 128 ports > we allocate the amount of idevs by using the number we get > from the kernel. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > --- > v1 -> v2: - reworked memory allocation into one calloc call > - added error path on allocation failure > v2 -> v3: - moved check for available nports to beginning of function >
Hmm. With this patch I see a segfault when I run usbip port command. I think this patch is incomplete and more changes are needed to the code that references the idev array.
I can't take this patch.
thanks, -- Shuah
| |